CMakeLists.txt: added missing control_toolbox dependencies #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests of joint_trajectory_controller need to depend on control_toolbox, oherwise, the (which should imho be in <> instead of "") will report No such file or directory when building against ros2_rolling source compile. Signed-off-by: Matthias Schoepfer <m.schoepfer@rethinkrobotics.com>
github-actions
bot
requested review from
bijoua29,
bmagyar,
destogl,
homalozoa,
jaron-l,
mhubii and
peterdavidfagan
bmagyar
approved these changes
Mar 16, 2022
destogl
approved these changes
Mar 19, 2022
Just out of curiosity, why do you think that? We are following “the rule” that inside |
|
@destogl : |
mechwiz
pushed a commit
to mechwiz/ros2_controllers
that referenced
this pull request
Apr 5, 2022
…ros-controls#315) Signed-off-by: Matthias Schoepfer <m.schoepfer@rethinkrobotics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests of joint_trajectory_controller need to depend on
control_toolbox, oherwise, the
(which should imho be in <> instead of "") will report
No such file or directory when building against ros2_rolling
source compile.
Signed-off-by: Matthias Schoepfer m.schoepfer@rethinkrobotics.com