Rename the "abort" variable in the joint traj controller #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aprotyas,
bmagyar,
destogl,
duringhof,
kellyprankin,
malapatiravi and
rosterloh
aprotyas
approved these changes
Jun 21, 2022
destogl
approved these changes
Jun 27, 2022
bmagyar
approved these changes
Jun 27, 2022
mamueluth
pushed a commit
to StoglRobotics-forks/ros2_controllers
that referenced
this pull request
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this name was misleading. There could be many reasons to abort a trajectory, including an abort request from the action client.
Looking at Line 200, this variable specifically means that we should abort because a joint tolerance was violated while moving.