Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting because pre-commit was not running on CI for some time. #409

Merged
merged 3 commits into from
Aug 15, 2022

Conversation

destogl
Copy link
Member

@destogl destogl commented Aug 10, 2022

depends on #408

@bmagyar please fix the generic execpt: lines in rqt_joint_trajectory_controller package. I am not sure which exceptions you are catching.

@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2022

This pull request is in conflict. Could you fix it @destogl?

@codecov-commenter
Copy link

Codecov Report

Merging #409 (65b41f1) into master (e7f9962) will decrease coverage by 5.79%.
The diff coverage is 20.43%.

@@            Coverage Diff             @@
##           master     #409      +/-   ##
==========================================
- Coverage   35.78%   29.98%   -5.80%     
==========================================
  Files         189        7     -182     
  Lines       17570      737   -16833     
  Branches    11592      422   -11170     
==========================================
- Hits         6287      221    -6066     
+ Misses        994      161     -833     
+ Partials    10289      355    -9934     
Flag Coverage Δ
unittests 29.98% <20.43%> (-5.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <ø> (ø)
...ontroller/test/test_load_diff_drive_controller.cpp 12.50% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 17.62% <12.08%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <13.33%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 20.00% <20.00%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 32.67% <24.59%> (ø)
...ollers/test/test_joint_group_effort_controller.cpp
...ller/test/test_load_forward_command_controller.cpp
...include/joint_trajectory_controller/trajectory.hpp
... and 192 more

@bmagyar bmagyar merged commit e718ae9 into master Aug 15, 2022
@bmagyar bmagyar deleted the fix-formatting branch August 15, 2022 08:13
mamueluth pushed a commit to StoglRobotics-forks/ros2_controllers that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants