[JTC] Disable use of closed-loop PID adapter if controller is used in open-loop mode. #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bmagyar,
harderthan,
jaron-l,
mcbed,
progtologist and
Serafadam
christophfroehlich
requested changes
Mar 31, 2023
There was a problem hiding this comment.
I agree, but let's add that to the doc.
open_loop_control (boolean)
Use controller in open-loop control mode using ignoring the states provided by hardware interface and using last commands as states in the next control step. This is useful if hardware states are not following commands, i.e., an offset between those (typical for hydraulic manipulators).
I did not understand that fully without looking at the code. This is only important for the start point of the interpolation (and now also disabling feedback PIDs -> comment on gains structure).
|
I uploaded a proposal for an update to the docs: StoglRobotics-forks#6 |
bmagyar
approved these changes
Apr 3, 2023
christophfroehlich
approved these changes
Apr 4, 2023
christophfroehlich
pushed a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Apr 11, 2023
christophfroehlich
added
the
backport-humble
christophfroehlich
pushed a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Aug 7, 2023
… open-loop mode. (ros-controls#551) (cherry picked from commit 8029a2f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the name says. It is not sensible to close loop using PID adapter if controller should run in the open-loop.