Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JTC] Implement new ~/controller_state message #578

Merged

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Apr 23, 2023

This is the humble version of #557, where the old msg format and topic is kept for legacy reasons.

I added a deprecation warning if one subscribes to the old ~/state topic

Needs ros-controls/control_msgs#87

@mergify
Copy link
Contributor

mergify bot commented Apr 23, 2023

This pull request is in conflict. Could you fix it @christophfroehlich?

Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Thanks!!!

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmagyar bmagyar merged commit c01b121 into ros-controls:humble May 2, 2023
8 of 12 checks passed
@christophfroehlich christophfroehlich deleted the jtc_new_state_format_humble branch May 2, 2023 21:48
JafarAbdi added a commit to JafarAbdi/ros2_controllers that referenced this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants