Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JTC] Implement new ~/controller_state message #557

Merged
merged 8 commits into from Apr 28, 2023

Conversation

christophfroehlich
Copy link
Contributor

This implements a state message for JTC following ros-controls/roadmap#57

Needs ros-controls/control_msgs#86

@christophfroehlich
Copy link
Contributor Author

I'm not sure how to handle the deprecations here.

Acc. to the roadmap, the topic should be ~/controller_state. How should we deal with the transition phase? Making a parameter with the topic name, defaulting to the old state and adding a deprecated warning if it is not changed to controller_state?

@christophfroehlich christophfroehlich marked this pull request as ready for review March 31, 2023 15:22
@christophfroehlich
Copy link
Contributor Author

We decided last WG meeting that we don't want to support the old msg format in rolling/iron. I'll add new PR for humble with proper deprecation warnings.

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2023

Codecov Report

Merging #557 (18b670e) into master (e7f9962) will decrease coverage by 3.31%.
The diff coverage is 26.60%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
- Coverage   35.78%   32.48%   -3.31%     
==========================================
  Files         189        7     -182     
  Lines       17570      665   -16905     
  Branches    11592      357   -11235     
==========================================
- Hits         6287      216    -6071     
+ Misses        994      157     -837     
+ Partials    10289      292    -9997     
Flag Coverage Δ
unittests 32.48% <26.60%> (-3.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontroller/test/test_load_diff_drive_controller.cpp 12.50% <0.00%> (ø)
diff_drive_controller/src/odometry.cpp 42.16% <11.11%> (ø)
diff_drive_controller/src/speed_limiter.cpp 46.55% <11.11%> (ø)
...ive_controller/test/test_diff_drive_controller.cpp 17.62% <12.08%> (ø)
...troller/include/diff_drive_controller/odometry.hpp 20.00% <20.00%> (ø)
...iff_drive_controller/src/diff_drive_controller.cpp 39.22% <35.50%> (ø)
...de/diff_drive_controller/diff_drive_controller.hpp 100.00% <100.00%> (ø)

... and 189 files with indirect coverage changes

@bmagyar bmagyar merged commit edd494c into ros-controls:master Apr 28, 2023
9 of 12 checks passed
@christophfroehlich christophfroehlich deleted the jtc_new_state_format branch April 29, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants