New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Steering odometry library and controllers (backport #484) #624
Conversation
I have PTSD from the original PR, not touching this for a while :D |
changing So the question is, should we have rcpputils backport the deprecation so we can have a similar codebase between humble and iron, or should i just request a merge for this fix? |
This is targeting humble so it is fine to chnage this. |
So regarding the update_reference_from_subscribers error, ChainableControllerInterface defines update_reference_from_subscribers without any args whereas in the humble definition we have with time and duration. |
@ARK3r this might solve it. I didn't compile locally, but the changes were rather trivial |
I'll test it in an hour and let you know. |
(cherry picked from commit 45d0083)
* fixing rolling_mean_accumulator issue * fixed variables' namespace
… have access to the proper time variable.
d6087f3
to
f77342f
Compare
@ARK3r I think I fixed everything. If you have time please confirm and we can merge this |
I'll build it rn. |
@destogl my demo is building and working as it did on rolling! 🥳🥳 also sorry about the delay, my build had issues... |
This is an automatic backport of pull request #484 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR on its base branch@Mergifyio update
will merge the base branch into this PR@Mergifyio backport <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com