Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steering odometry library and controllers (backport #484) #624

Merged
merged 6 commits into from Jun 1, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 27, 2023

This is an automatic backport of pull request #484 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@bmagyar
Copy link
Member

bmagyar commented May 27, 2023

I have PTSD from the original PR, not touching this for a while :D

@ARK3r
Copy link
Contributor

ARK3r commented May 31, 2023

changing rcpputils to rcppmath resolves this issue however it seems that in rolling rcppmath is deprecated in favour of rcpputils.

So the question is, should we have rcpputils backport the deprecation so we can have a similar codebase between humble and iron, or should i just request a merge for this fix?

@destogl
Copy link
Member

destogl commented May 31, 2023

changing rcpputils to rcppmath resolves this issue however it seems that in rolling rcppmath is deprecated in favour of rcpputils.

This is targeting humble so it is fine to chnage this.

@ARK3r
Copy link
Contributor

ARK3r commented May 31, 2023

#637

@ARK3r
Copy link
Contributor

ARK3r commented May 31, 2023

@destogl
Copy link
Member

destogl commented May 31, 2023

@ARK3r this might solve it. I didn't compile locally, but the changes were rather trivial

@ARK3r
Copy link
Contributor

ARK3r commented May 31, 2023

I'll test it in an hour and let you know.

@destogl
Copy link
Member

destogl commented May 31, 2023

@ARK3r I think I fixed everything. If you have time please confirm and we can merge this

@ARK3r
Copy link
Contributor

ARK3r commented May 31, 2023

I'll build it rn.

@ARK3r
Copy link
Contributor

ARK3r commented May 31, 2023

@destogl my demo is building and working as it did on rolling! 🥳🥳

also sorry about the delay, my build had issues...

@destogl destogl merged commit ad30ca2 into humble Jun 1, 2023
10 of 12 checks passed
@destogl destogl deleted the mergify/bp/humble/pr-484 branch June 1, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants