Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapted rqt_jtc to newest control_msgs for jtc #643

Merged
merged 1 commit into from Jun 4, 2023
Merged

Adapted rqt_jtc to newest control_msgs for jtc #643

merged 1 commit into from Jun 4, 2023

Conversation

gwalck
Copy link
Contributor

@gwalck gwalck commented Jun 2, 2023

solves #642

destogl
destogl approved these changes Jun 2, 2023
View reviewed changes
Copy link
Member

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks good!

bmagyar
bmagyar approved these changes Jun 4, 2023
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only looks good but I found the same issue last week and also tested this against my old setup. Thanks!

@bmagyar bmagyar merged commit b47b42d into ros-controls:master Jun 4, 2023
12 of 13 checks passed
@bmagyar bmagyar added the backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. label Jun 11, 2023
mergify bot pushed a commit that referenced this pull request Jun 11, 2023
@gwalck @mergify
Adapted rqt_jtc to newest control_msgs for jtc (#643)
9468a7e 
(cherry picked from commit b47b42d)
@mergify mergify bot mentioned this pull request Jun 11, 2023
Merged
@destogl destogl deleted the rqt_jtc_new_ctrl_msg branch June 21, 2023 17:45
@christophfroehlich christophfroehlich mentioned this pull request Dec 7, 2023
Closed
christophfroehlich pushed a commit that referenced this pull request Dec 7, 2023
@gwalck @christophfroehlich
Adapted rqt_jtc to newest control_msgs for jtc (#643)
f00c8ab 
(cherry picked from commit b47b42d)
@christophfroehlich christophfroehlich mentioned this pull request Dec 9, 2023
Closed
christophfroehlich pushed a commit that referenced this pull request Dec 10, 2023
@mergify @gwalck
Adapted rqt_jtc to newest control_msgs for jtc (#643) (#659)
8dfc247 
(cherry picked from commit b47b42d)

Co-authored-by: gwalck <guillaume.walck@stoglrobotics.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@destogl destogl destogl approved these changes

@bmagyar bmagyar bmagyar approved these changes

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gwalck @destogl @bmagyar