Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JTC] Increase action tests timeout #680

Merged
merged 1 commit into from
Jun 25, 2023
Merged

[JTC] Increase action tests timeout #680

merged 1 commit into from
Jun 25, 2023

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Jun 20, 2023 •
edited

The test failed locally in my docker and also here

However, there might be something still wrong with the clock -> fix comes with a different PR.

4: [ RUN ] OnlyEffortTrajectoryControllers/TestTrajectoryActionsTestParameterized.test_goal_tolerances_fail/0
4: [INFO] [1687297889.159827233] [test_joint_trajectory_controller]: No specific joint names are used for command interfaces. Using 'joints' parameter.
4: [INFO] [1687297889.159858902] [test_joint_trajectory_controller]: Command interfaces are [effort] and state interfaces are [position velocity].
4: [INFO] [1687297889.159869506] [test_joint_trajectory_controller]: Using 'splines' interpolation method.
4: [INFO] [1687297889.160144563] [test_joint_trajectory_controller]: Action status changes will be monitored at 20.00 Hz.
4: [INFO] [1687297889.461739408] [test_joint_trajectory_controller]: Received new action goal
4: [INFO] [1687297889.461780570] [test_joint_trajectory_controller]: Accepted new action goal
4: [WARN] [1687297889.461844027] [test_joint_trajectory_controller]: Aborted due goal_time_tolerance exceeding by 1687208373.175506 seconds
4: [ OK ] OnlyEffortTrajectoryControllers/TestTrajectoryActionsTestParameterized.test_goal_tolerances_fail/0 (2022 ms)

@christophfroehlich christophfroehlich changed the title Increase action tests timeout [JTC] Increase action tests timeout Jun 20, 2023
@christophfroehlich christophfroehlich mentioned this pull request Jun 20, 2023
Closed
@christophfroehlich christophfroehlich marked this pull request as ready for review June 25, 2023 16:26
@bmagyar bmagyar merged commit fd89df5 into ros-controls:jtc-features Jun 25, 2023
8 checks passed
bmagyar pushed a commit that referenced this pull request Jun 26, 2023
@christophfroehlich @bmagyar
Increase action tests timeout (#680)
bc0f3fc
@christophfroehlich christophfroehlich mentioned this pull request Jul 17, 2023
Merged
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Jul 17, 2023
@christophfroehlich
Increase action tests timeout (ros-controls#680)
6e6989d
bmagyar pushed a commit that referenced this pull request Jul 17, 2023
@christophfroehlich @bmagyar
Increase action tests timeout (#680)
8674f2d
mergify bot pushed a commit that referenced this pull request Jul 17, 2023
@christophfroehlich @mergify
Increase action tests timeout (#680)
41fb251 
(cherry picked from commit 8674f2d)

# Conflicts:
#	joint_trajectory_controller/CMakeLists.txt
mergify bot pushed a commit that referenced this pull request Jul 17, 2023
@christophfroehlich @mergify
Increase action tests timeout (#680)
4dcd1b1 
(cherry picked from commit 8674f2d)

# Conflicts:
#	joint_trajectory_controller/CMakeLists.txt
@christophfroehlich christophfroehlich deleted the jtc_action_tests branch July 25, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmagyar bmagyar bmagyar approved these changes

@destogl destogl Awaiting requested review from destogl

@jackcenter jackcenter Awaiting requested review from jackcenter

@livanov93 livanov93 Awaiting requested review from livanov93

@malapatiravi malapatiravi Awaiting requested review from malapatiravi

@mcbed mcbed Awaiting requested review from mcbed

@VanshGehlot VanshGehlot Awaiting requested review from VanshGehlot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@christophfroehlich @bmagyar