Fixed period computation in test #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please run |
Sorry, I know this, did it several times, and for the PR (which is only a single change compared to many I did), I did a cherry-pick and apparently this introduced a line. I forgot to re-run. I think I had a reason to not "install" the pre-commit but I forgot which one. |
|
I find precommit on every commit to be slowing my work down and be generally annoying so I also never actually run |
bmagyar
added
the
backport-humble
|
@Mergifyio backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
(cherry picked from commit de7083e)
christophfroehlich
pushed a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Jul 17, 2023
christophfroehlich
pushed a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Jul 17, 2023
bmagyar
pushed a commit
that referenced
this pull request
Jul 17, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
(cherry picked from commit 88c3463)
mergify bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
(cherry picked from commit 88c3463)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed and confirmed in #686 there seem to be a wrong computation of the period (dt) passed to
traj_controller->updatein theUpdateControllertest helper function.Fixing it does not make tests fail, but is, first necessary to avoid keeping wrong computations, and second for future up-coming improvement that relies on dt to update the state interface as well.