-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JTC] Reject messages with effort fields #699
[JTC] Reject messages with effort fields #699
Conversation
What sort of error / result code would clients see? A single |
The message will be rejected, which means that nothing moves and the user will have a look in the command prompt. What else do you suggest? |
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Abrar Rahman Protyasha <a_protyasha@apple.com>
I guess I would phrase this as:
that's what I meant when I wrote:
I've been such a confused user in the past, hence my comment.
Last time I checked, there was no support for setting the error_code or the error_string as part of the rejection, as you could in ROS 1 (ros2/rclc#271). That complicates things, but a work-around I've seen is to accept the goal, then 'abort' by never processing it and immediately sending the final result, in which you set the Clearly a work-around, and I still consider the limitation discussed in the linked issue a serious design flaw, but it seems without some work, the best you can do. The advantage of doing something like this is that clients would have machine readable information about what happened to their goal. "the human needs to look at the command line" is not a viable error handling / recovery strategy in many cases, so should be avoided as much as possible. The |
The check introduced with this PR just follows the way the trajectory message gets rejected with any other errors. So I suggest discussing your point in a separate issue, because we then would have to change the overall behavior of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Especially like negative sum of changes!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks @gavanderhoorn for the insightful comments, it's worth tracking that on a separate issue. |
We decided in the last WG meeting (see here for the referece) to reject incoming trajectory messages having effort entries for now. If someone needs this, we have to discuss how to interpolate effort.
Together with 0f84024 this closes #688