Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashing update #7

Merged
merged 6 commits into from Feb 6, 2020
Merged

Dashing update #7

merged 6 commits into from Feb 6, 2020

Conversation

Karsten1987
Copy link
Contributor

@Karsten1987
use dashing rclcpp logger interface
25c4fda 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
@Karsten1987
avoid deprecated publisher and subscribe API
f574d94 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
@Karsten1987 Karsten1987 self-assigned this Aug 8, 2019
@Karsten1987 Karsten1987 mentioned this pull request Aug 19, 2019
Closed
Karsten1987 and others added 2 commits August 20, 2019 16:25
@Karsten1987
use dashing parameter API
93d152b 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Update build to dashing
9001021 
Signed-off-by: Anas Abou Allaban <allabana@amazon.com>
@Karsten1987
Copy link
Contributor Author

Karsten1987 commented Feb 3, 2020 •
edited

@piraka9011 @bmagyar this is up for review.

We have to land these changes in order to make dashing work and branch off to master correctly.

I've actually changed the base branch for this PR to master and will cherry-pick this commit on top of dashing for the backport.

@Karsten1987
Copy link
Contributor Author

@piraka9011 how come that all these commits are already on master? I don't see a PR attached to this? Do you push all the commits of this PR onto master?

@piraka9011
Copy link
Contributor

@Karsten1987 It looks like when making the master branch I created it off dashing_update and not dashing so that CI passes.
We can rebase master on to dashing instead and work from there.

@Karsten1987
Copy link
Contributor Author

the problem with this is that we have duplicate commits now.
Also, the current master seems to be broken: ros-controls/ros2_control#42

@Karsten1987
apply to master API
70e799f 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
@Karsten1987 Karsten1987 mentioned this pull request Feb 5, 2020
Merged
@Karsten1987
address windows warnings
af4ef16 
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
@Karsten1987
Copy link
Contributor Author

CI came back green, merging.

@Karsten1987 Karsten1987 merged commit 1d2c7f0 into dashing Feb 6, 2020
@Karsten1987 Karsten1987 deleted the dashing_update branch February 6, 2020 00:51
@zacharyyamaoka zacharyyamaoka mentioned this pull request Mar 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piraka9011 piraka9011 piraka9011 approved these changes

Assignees

@Karsten1987 Karsten1987

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Karsten1987 @piraka9011