[JTC] Generate parameter library namespace #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bijoua29,
bmagyar,
DasRoteSkelett,
destogl,
livanov93,
LukasMacha97 and
qiayuanl
This was referenced Jul 14, 2023
christophfroehlich
force-pushed
the
jtc-parameters
branch
from
15f6bb1
to
b9dc169
Compare
|
Failing CI is again because of of admittance controller and should not be related to this PR. |
bmagyar
approved these changes
Jul 16, 2023
|
The gmock issue is legit |
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Jul 17, 2023
christophfroehlich
added a commit
to christophfroehlich/ros2_controllers
that referenced
this pull request
Jul 17, 2023
bmagyar
pushed a commit
that referenced
this pull request
Jul 17, 2023
mergify bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
(cherry picked from commit e49c540) # Conflicts: # joint_trajectory_controller/include/joint_trajectory_controller/validate_jtc_parameters.hpp
mergify bot
pushed a commit
that referenced
this pull request
Jul 17, 2023
(cherry picked from commit e49c540) # Conflicts: # joint_trajectory_controller/include/joint_trajectory_controller/validate_jtc_parameters.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The namespace of the parameter validators were changed with PickNikRobotics/generate_parameter_library@44b5576
I updated that now in the validator header file.