Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JTC] Reject messages with effort fields (#699) #719

Merged
merged 1 commit into from
Jul 25, 2023
Merged

[JTC] Reject messages with effort fields (#699) #719

merged 1 commit into from
Jul 25, 2023

Conversation

bmagyar
Copy link
Member

@bmagyar bmagyar commented Jul 25, 2023

Cherry-picked #699 to target master

christophfroehlich
christophfroehlich approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cherrypicking!

@bmagyar bmagyar merged commit a572381 into master Jul 25, 2023
13 of 14 checks passed
@bmagyar bmagyar deleted the jtc-leftovers branch July 25, 2023 11:52
@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. label Aug 3, 2023
mergify bot pushed a commit that referenced this pull request Aug 3, 2023
@bmagyar @mergify
[JTC] Reject messages with effort fields (#699) (#719)
17e14e3 
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
(cherry picked from commit a572381)

# Conflicts:
#	joint_trajectory_controller/test/test_trajectory_controller.cpp
@mergify mergify bot mentioned this pull request Aug 3, 2023
Closed
christophfroehlich pushed a commit to christophfroehlich/ros2_controllers that referenced this pull request Aug 7, 2023
@bmagyar @christophfroehlich
[JTC] Reject messages with effort fields (ros-controls#699) (ros-cont…
e46585c 
…rols#719)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
(cherry picked from commit a572381)
bmagyar pushed a commit that referenced this pull request Aug 7, 2023
@christophfroehlich
[JTC] Reject messages with effort fields (#699) (#719) (#738)
6a4e7a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophfroehlich christophfroehlich christophfroehlich approved these changes

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@DasRoteSkelett DasRoteSkelett Awaiting requested review from DasRoteSkelett

@destogl destogl Awaiting requested review from destogl

@erickisos erickisos Awaiting requested review from erickisos

@jaron-l jaron-l Awaiting requested review from jaron-l

@mcbed mcbed Awaiting requested review from mcbed

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bmagyar @christophfroehlich