Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JTC] Fix dynamic reconfigure of tolerances #849

Merged

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Nov 19, 2023

#761 had a little issue: The tolerances were only updated with use_closed_loop_pid_adapter_ being true.
I changed this and added a test for updating the fields of the constraints parameters.

@christophfroehlich christophfroehlich added the backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. label Nov 19, 2023
Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Merging #849 (ff80929) into master (25f2a14) will decrease coverage by 0.61%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #849      +/-   ##
==========================================
- Coverage   45.53%   44.93%   -0.61%     
==========================================
  Files          40       40              
  Lines        3654     3654              
  Branches     1724     1724              
==========================================
- Hits         1664     1642      -22     
- Misses        810      834      +24     
+ Partials     1180     1178       -2     
Flag Coverage Δ
unittests 44.93% <0.00%> (-0.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ory_controller/src/joint_trajectory_controller.cpp 47.76% <0.00%> (+0.13%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good catch!

@bmagyar bmagyar merged commit d9a6bb4 into ros-controls:master Nov 19, 2023
11 of 14 checks passed
mergify bot pushed a commit that referenced this pull request Nov 19, 2023
* Fix dynamic reconfigure of tolerances

* Fix static cast syntax

(cherry picked from commit d9a6bb4)
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 19, 2023
* Fix dynamic reconfigure of tolerances

* Fix static cast syntax
@christophfroehlich christophfroehlich deleted the jtc/reconfigure_tolerances branch November 19, 2023 22:00
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 27, 2023
* Fix dynamic reconfigure of tolerances

* Fix static cast syntax
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 29, 2023
* Fix dynamic reconfigure of tolerances

* Fix static cast syntax
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 29, 2023
* Fix dynamic reconfigure of tolerances

* Fix static cast syntax
bmagyar pushed a commit that referenced this pull request Nov 30, 2023
* Fix dynamic reconfigure of tolerances

* Fix static cast syntax
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 30, 2023
* Fix dynamic reconfigure of tolerances

* Fix static cast syntax
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Dec 5, 2023
* Fix dynamic reconfigure of tolerances

* Fix static cast syntax
bmagyar pushed a commit that referenced this pull request Dec 6, 2023
* Fix dynamic reconfigure of tolerances

* Fix static cast syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants