Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage #856

Merged

Conversation

christophfroehlich
Copy link
Contributor

Adding simple test conditions with calls of

  command_interface_configuration();
  state_interface_configuration();

to increase test coverage of some controllers/broadcasters.

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Merging #856 (a0f932c) into master (0d3fc52) will increase coverage by 1.65%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #856      +/-   ##
==========================================
+ Coverage   44.88%   46.53%   +1.65%     
==========================================
  Files          40       40              
  Lines        3636     3636              
  Branches     1716     1716              
==========================================
+ Hits         1632     1692      +60     
+ Misses        832      761      -71     
- Partials     1172     1183      +11     
Flag Coverage Δ
unittests 46.53% <ø> (+1.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Nov 25, 2023
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this is super nice, thank you!

@bmagyar bmagyar merged commit b6841ea into ros-controls:master Nov 27, 2023
13 of 15 checks passed
mergify bot pushed a commit that referenced this pull request Nov 27, 2023
mergify bot pushed a commit that referenced this pull request Nov 27, 2023
@christophfroehlich christophfroehlich deleted the increase_test_coverage branch November 27, 2023 12:06
christophfroehlich added a commit to christophfroehlich/ros2_controllers that referenced this pull request Nov 29, 2023
christophfroehlich added a commit that referenced this pull request Dec 4, 2023
christophfroehlich added a commit that referenced this pull request Dec 6, 2023
christophfroehlich added a commit that referenced this pull request Dec 6, 2023
christophfroehlich added a commit that referenced this pull request Dec 10, 2023
christophfroehlich added a commit that referenced this pull request Dec 10, 2023
christophfroehlich added a commit that referenced this pull request Dec 11, 2023
christophfroehlich added a commit that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants