[JTC] Fill action error_strings #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
added
backport-humble
christophfroehlich
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #887 +/- ##
==========================================
+ Coverage 47.71% 47.72% +0.01%
==========================================
Files 41 41
Lines 3871 3876 +5
Branches 1833 1832 -1
==========================================
+ Hits 1847 1850 +3
Misses 751 751
- Partials 1273 1275 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
saikishor
reviewed
Dec 7, 2023
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
christophfroehlich
force-pushed
the
jtc/error_strings
branch
from
cbf28cf
to
446f8ed
Compare
christophfroehlich
force-pushed
the
jtc/error_strings
branch
from
446f8ed
to
c121b99
Compare
bmagyar
reviewed
Jan 14, 2024
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
bmagyar
reviewed
Jan 14, 2024
joint_trajectory_controller/src/joint_trajectory_controller.cpp
Outdated
Show resolved
Hide resolved
christophfroehlich
force-pushed
the
jtc/error_strings
branch
from
8ab1d8a
to
dc1c494
Compare
Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
christophfroehlich
force-pushed
the
jtc/error_strings
branch
from
dc1c494
to
8630382
Compare
mergify bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
(cherry picked from commit 67dbf7b)
mergify bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
(cherry picked from commit 67dbf7b)
This was referenced Jan 31, 2024
bmagyar
pushed a commit
that referenced
this pull request
Jan 31, 2024
bmagyar
pushed a commit
that referenced
this pull request
Jan 31, 2024
pac48
pushed a commit
to pac48/ros2_controllers
that referenced
this pull request
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out that the
control_msgs::action::FollowJointTrajectoryhas an error_string field, but it was not populated in some cases.