Add tests for interface_configuration_type consistently
#899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophfroehlich
added
backport-humble
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #899 +/- ##
==========================================
- Coverage 47.81% 47.61% -0.21%
==========================================
Files 41 41
Lines 3871 3871
Branches 1827 1827
==========================================
- Hits 1851 1843 -8
- Misses 751 760 +9
+ Partials 1269 1268 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
christophfroehlich
removed
the
backport-humble
|
Should be backported to humble after #865 got merged |
saikishor
approved these changes
Dec 10, 2023
christophfroehlich
force-pushed
the
interface_tests
branch
from
a9cd4ff
to
df2c143
Compare
christophfroehlich
force-pushed
the
interface_tests
branch
from
df2c143
to
8cac8cc
Compare
github-actions
bot
requested review from
arne48,
duringhof,
fmauch,
progtologist and
saikishor
saikishor
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
@christophfroehlich Thank you so much for the work!
The changes look great to me :)
mergify bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
(cherry picked from commit f2f36c0) # Conflicts: # pid_controller/test/test_pid_controller.cpp # pid_controller/test/test_pid_controller_preceding.cpp
christophfroehlich
added
the
backport-humble
mergify bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
(cherry picked from commit f2f36c0) # Conflicts: # pid_controller/test/test_pid_controller.cpp # pid_controller/test/test_pid_controller_preceding.cpp
bmagyar
pushed a commit
that referenced
this pull request
Feb 1, 2024
pac48
pushed a commit
to pac48/ros2_controllers
that referenced
this pull request
Feb 2, 2024
bmagyar
pushed a commit
that referenced
this pull request
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added tests for every
controller_interface::interface_configuration_typeas @saikishor mentioned here. (and fixed some typos)