Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly remove subscription from wait_for WaitSet #1106

Closed
wants to merge 4 commits into from

Conversation

dhood
Copy link

@dhood dhood commented Apr 26, 2024

Prototype fix for #1101 馃

Copy link
Contributor

mergify bot commented Apr 26, 2024

@dhood, all pull requests must be targeted towards the master development branch.
Once merged into master, it is possible to backport to ci_noble, but it must be in master
to have these changes reflected into new distributions.

@dhood dhood marked this pull request as draft April 26, 2024 19:10
@dhood dhood changed the base branch from ci_noble to master April 26, 2024 19:12
@dhood dhood marked this pull request as ready for review April 26, 2024 19:14
@dhood
Copy link
Author

dhood commented Apr 26, 2024

hey guys what's the trick to getting CI to trigger around here 馃槅
(edit: seems a-go now 馃憤 ; forgive me for using CI to experiment! no src checkout locally)

@christophfroehlich
Copy link
Contributor

hey guys what's the trick to getting CI to trigger around here 馃槅

a maintainer has to approve CI for first-time contributors ;)

@dhood
Copy link
Author

dhood commented Apr 28, 2024

needed a new commit first to retrigger the CI request, after retargeting to master, first!
but nvm, this approach doesn't work! was optimistic that the issue was at the spinning, but it's before that, which is a harder thing to address.

SO the low-hanging fruit patch didn't conveniently fix this, so I'll close this in favour of a more invasive fix. it's less likely I'll have time for that but not impossible, since I am nerd-sniped ;)

@dhood dhood closed this Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants