-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add AckermannDriveStamped control to steering library #1171
base: iron
Are you sure you want to change the base?
Conversation
@wittenator, all pull requests must be targeted towards the |
Ah hmm, I can't move our software stack to Jazzy (due to Nvidia dependencies) and therefore have to develop these changes on Iron. Should I develop the feature completely on Iron and then cherry-pick the changes on top of the master? The drawback is that I can't really test in on the master besides a few unit tests maybe. |
Let's merge #1150 first, and then proceed with this one here. Could you please review it and give your feedback (Files changed -> Review changes)? |
This pull request is in conflict. Could you fix it @wittenator? |
This PR adds the option to use steering angle and linear velocity for controllers that inherit from the steering library. In anticipation of the merging and backport of the fixes in the ackermann controller, I branched off of the fix/steering_controllers_library_kinematics branch and cherry-picked the changes on top of the iron branch.
Status:
colcon test
andpre-commit run
(requires you to install pre-commit bypip3 install pre-commit
)