[JointTrajectoryController] Add test for param propagation from overrides (e.g. yaml files) #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
livanov93
changed the title
|
Can be tested in a right way when #rclcpp/PR1596 is used. This is not possible for foxy binaries. Closing for now. |
gwalck
pushed a commit
to StoglRobotics-forks/ros2_controllers
that referenced
this pull request
Jun 7, 2023
* introducing handles Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * component interfaces & tests Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * linters Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * import resource manager Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * correct year Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * import handles from loaded components Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * wip / debug Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * parse components Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * changes after rebase Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * component parser as shared library Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * validate urdf configuratin Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * documentation Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * remove default constructor Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * resource loaning Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * loan state interface Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * import externally declared components Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * move resource manager to hardware interface (ros-controls#226) * move resource manager to hardware interface Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> * include functional for std::function Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> * address review comments Signed-off-by: Karsten Knese <Karsten1987@users.noreply.github.com> Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR includes test for parameter propagation when loaded via overrides. It should help in reviewing #224
colcon test --packages-select joint_trajectory_controller --event-handlers console_cohesion+ desktop_notification+ status+ terminal_title+ summary+ console_direct+ --ctest-args -R test_trajectory_controller