Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tricycle Controller #344

Closed
wants to merge 1 commit into from

Conversation

tonynajjar
Copy link
Contributor

@tonynajjar tonynajjar commented May 2, 2022

Hey! We at Pixel Robotics recently started our migration to ros2_control. We are in the process of creating a tricycle controller and decided to contribute back.

This PR is not yet complete but we wanted to get a first feedback round already.

The main things still in progress are:

1- The process_twist_command still needs some logic to take care of corner cases to make the navigation smoother

2- We have a particular need (that might actually be generalized for other people) to apply some safety validation on the steering angle (alpha) and wheel speed (Ws) according to the robot state (e.g sensors triggered) before sending it to the HW interface. This validation is done in a separate node that contains the state of the robot, this is why we publish the steering angle and wheel speed in update() and send the validated commands in send_command().
This surely looks like bad practice as it increases latency, how else would you do it?

@bmagyar
Copy link
Member

bmagyar commented May 2, 2022

Thanks for the contribution! Could you please retarget the PR to the master branch? We don't add new features to already released distros, only backport them from Rolling

@tonynajjar
Copy link
Contributor Author

tonynajjar commented May 2, 2022

I was suspecting so, will do, I think there are minor changes I will need to do

@tonynajjar
Copy link
Contributor Author

done #345

@tonynajjar tonynajjar closed this May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants