Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! We at Pixel Robotics recently started our migration to ros2_control. We are in the process of creating a tricycle controller and decided to contribute back.
This PR is not yet complete but we wanted to get a first feedback round already.
The main things still in progress are:
1- The process_twist_command still needs some logic to take care of corner cases to make the navigation smoother
2- We have a particular need (that might actually be generalized for other people) to apply some safety validation on the steering angle (alpha) and wheel speed (Ws) according to the robot state (e.g sensors triggered) before sending it to the HW interface. This validation is done in a separate node that contains the state of the robot, this is why we publish the steering angle and wheel speed in
update()
and send the validated commands insend_command()
.This surely looks like bad practice as it increases latency, how else would you do it?