Remove deprecated parameter hold_trajectory_duration #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmagyar
approved these changes
Nov 21, 2018
bmagyar
requested changes
Nov 21, 2018
| @@ -229,6 +229,7 @@ bool JointTrajectoryController<SegmentImpl, HardwareInterface>::init(HardwareInt | |||
|
|
|||
| // Stop trajectory duration | |||
| stop_trajectory_duration_ = 0.0; | |||
| controller_nh_.getParam("stop_trajectory_duration", stop_trajectory_duration_); | |||
There was a problem hiding this comment.
For semantic reasons I'd prefer
stop_trajectory_duration_ = controller_nh_.param("stop_trajectory_duration", 0.0);
There was a problem hiding this comment.
There is a copy&paste bug in the new commit. I rolled back to the original version again.
In addition the other parameters are retrieved the same way, so let's keep it like this for now.
|
Tests pass again, |
mathias-luedtke
changed the title
bmagyar
approved these changes
Nov 22, 2018
AndyZe
force-pushed
the
melodic-remove-deprecated-warning
branch
from
f8a907a
to
c7ef6e6
Compare
AdamPettinger
pushed a commit
to UTNuclearRobotics/ros_controllers
that referenced
this pull request
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.