[melodic] add missing pluginlib deps. #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bmagyar This is ready for review and merge. Thanks! |
|
It looks like the CI does build but there are some test failures. However, those failure are also manifesting on the upstream, so I figure they are safe to ignore? |
|
@seanyen thank you for spotting this, I am re-running the CI to sort out the flaky tests. |
bmagyar
approved these changes
Feb 10, 2020
alcantara09
pushed a commit
to alcantara09/ros_controllers
that referenced
this pull request
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent refactoring work done in
ros_controlhas removed the extra dependencies topluginliband which makes the downstream projects, which depends onpluginlibbut have not yet to be explicit on that, have build breaks when runningcatkin_make_isolated.This pull request is to be explicitly adding the dependencies on
pluginlibfor the project using plugin model.