Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joint trajectory controller: Send empty msg through action interface #70

Closed
adolfo-rt opened this issue Dec 4, 2013 · 0 comments
Closed
Assignees

Comments

@adolfo-rt
Copy link
Member

I just discovered that sending an empty message through the action interface does not have the same behavior as PR2's JointTrajectoryActionController:

  • PR2: Reject goal because joint list (empty) doesn't match those of the controller.
  • ros_controllers: Accept goal and have the same effect as sending an empty msg trough the topic interface: cancel all queued trajectory segments.

In the ros_controllers case, an unexpected behavior of its current implementation is that after accepting the empty goal, it remains active. Not very intuitive. I'm opting for maintaining the behavior of the PR2 controller, maybe someone even depends on that.

@ghost ghost assigned adolfo-rt Dec 4, 2013
adolfo-rt pushed a commit to pal-robotics-forks/ros_controllers that referenced this issue Dec 4, 2013
adolfo-rt pushed a commit that referenced this issue Dec 4, 2013
Action interface rejects empty goals. Fixes #70.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant