Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for velocity_controllers::JointTrajectoryController #228

Merged

Conversation

miguelprada
Copy link
Contributor

This PR adds a VelocityJointInterface to RRBot, and duplicates the tests being run for the position-based joint trajectory controller.

@bmagyar
Copy link
Member

bmagyar commented Aug 2, 2016

ok Miguel, one last thing: could you please squash your commits on this PR?

@miguelprada
Copy link
Contributor Author

Done. I also rebased on top of the current kinetic-devel while I was on it, since the only commit that was there was something on the travis configuration. Hope this is fine.

@miguelprada
Copy link
Contributor Author

miguelprada commented Aug 3, 2016

After squashing and rebasing I found a compilation error which made the CI job fail. It had to do with the API change introduced in ros-controls/ros_control@afaf940, and I'm not quite sure how it flew under my radar (probably some messed up workspace with indigo-devel branch of ros_control).

Anyways, after fixing it, the travis job still fails, only this time on some diff_drive_controller test. Don't think there's anything I should do about this, right?

@bmagyar
Copy link
Member

bmagyar commented Oct 26, 2016

Thanks for sticking around with this one, merging...

@bmagyar bmagyar merged commit 426d1a9 into ros-controls:kinetic-devel Oct 26, 2016
@miguelprada miguelprada deleted the velocity_iface_tests branch May 12, 2017 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants