Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wav data type for audio_capture and audio_play (ros ticket #14) #14

Closed
ahendrix opened this issue Mar 14, 2013 · 5 comments
Closed

Comments

@ahendrix
Copy link
Contributor

I'd like to use wav file type at audio_capture and audio_play.
So, I write a patch for using wav file. It can change data format by parameter.

trac data:

@ahendrix
Copy link
Contributor Author

[ahendrix] The patch to audio_capture looks nice and clean.

It looks like the patch to audio_play contains a lot of duplicated and dead code; is there any way to clean that up?

Can you add test cases for your new functionality?

@ahendrix
Copy link
Contributor Author

[yoheikakiuchi] I added audio_common_wav_R1.patch.
I have cleaned up code and added test directory for launch files.

@78226415
Copy link

I have try to use wav file for out put, then i download the source code of audio_capture, and change the code :
ros::param::paramstd::string("~format", _format, "mp3");
to
ros::param::paramstd::string("~format", _format, "wave");
when i run the project, it get an error:
[ERROR] [1466752230.167599944]: Unsupported media type.
i try to look for more information, the return is "false" from the code :
link_ok = gst_element_link_many( _source, _sink, NULL);

Could some one kindly help me? thanks.

@trainman419
Copy link
Contributor

@78226415 myself and the other package maintainers get notifications for every ticket and comment. Please do not post multiple times for the same issue.

@knorth55
Copy link
Member

wav data type is supported for audio_play and audio_capture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants