Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing target (Cm3) and switch to find_package script. #11

Merged
merged 2 commits into from
Sep 25, 2018

Conversation

helenol
Copy link
Contributor

@helenol helenol commented Aug 31, 2018

This fixes 2 issues I encountered while trying to run the library from the pre-built kinetic version on Ubuntu 16.04.

  1. libCm3.so isn't exported/installed properly, so the nodelet was failing to load when trying to launch camera.launch
    a. Fix: export Cm3 as an install target.
  2. My pre-installed version of the Spinnaker SDK wasn't being found (or wasn't finding the include directories) when trying to build from source.
    b. Fix: switch to find_package and provide a cmake find script.
    c. Fix: also find the include directories in the package script.

Let me know if you're ok with the cmake script, otherwise I can take it out but definitely Cm3 should be installed as a target.

With these fixes, it works fine for me from source with an self-installed SDK. :)

@mhosmar-cpr
Copy link
Member

mhosmar-cpr commented Sep 25, 2018

Hi @helenol !
Sorry i didn't see this earlier. I am just noticing the same issue you did. I am only having one issue with the script. It seems to find the libSpinnaker.so in the install folder if you do two release builds in a row but not the header. I think this can be fixed by just using Spinnaker_FOUND instead of Spinnaker_LIBRARIES. The install directive for the spinnaker library also needs updating so it will still work. Ill merge this then link the change I'm talking about.

@mhosmar-cpr mhosmar-cpr merged commit 7562b63 into ros-drivers:kinetic-devel Sep 25, 2018
@mhosmar-cpr
Copy link
Member

Commit 8c46088 shows the changes I made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants