Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added udev rule #132

Merged
merged 3 commits into from Oct 2, 2023
Merged

Conversation

hilary-luo
Copy link
Contributor

Ported udev rule from noetic branch to humble branch

Copy link
Collaborator

@berndpfrommer berndpfrommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to better understand how this file is used, as it is not directly referenced in the CMakefile? Currently udev files (if necessary) are created manually as per these instructions

@tonybaltovski
Copy link
Member

It gets added to the debian packaging after blooming like here: https://github.com/ros-drivers-gbp/flir_camera_driver-release/tree/debian/noetic/spinnaker_camera_driver/debian and will automatically be installed into /usr/lib/udev/rules.d as 60-ros-humble-spinnaker-camera-driver.rules.

Copy link
Collaborator

@berndpfrommer berndpfrommer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also support vendor ID 0x1724 then? That's Teledyne. That way we cover the same hardware as the SDK:

SUBSYSTEM=="usb", ATTRS{idVendor}=="1e10", GROUP="flirimaging"
SUBSYSTEM=="usb", ATTRS{idVendor}=="1724", GROUP="flirimaging"

And is there a specific reason to set the mode to 0666? Wouldn't that give read/write permissions to "other", i.e. non-members of the flirimaging group?

@tonybaltovski
Copy link
Member

tonybaltovski commented Sep 29, 2023

For the 666 permissions, it would allow non-group access so you don't have to add the user to group.

@berndpfrommer
Copy link
Collaborator

That any user could open the camera is certainly not improving security. If somebody hacked into a robot they could look through the camera and potentially see classified stuff in the lab. If it were to me I'd leave it the way FLIR ships their SDK, which is without the 666 mode. But I don't have strong feelings about it, and I can understand if Clearpath does not want to deal with customers struggling with denied camera access. I leave it up to you to decide.
That's it from my end, I think the PR is good to proceed.

@tonybaltovski
Copy link
Member

@berndpfrommer for security, we think it is better to use '660' as you said and we will add our default user to the correct group.

@tonybaltovski tonybaltovski merged commit 752a61e into ros-drivers:humble-devel Oct 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants