Initialize variable #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sure, but such issues are expected when there's no real review done. Thanks for following up with this, the change makes sense based on how that flag is being used. |
wep21
reviewed
Feb 15, 2022
|
|
||
| WORKDIR /work/gscam_ws/src | ||
|
|
||
| RUN git clone https://github.com/ros-drivers/gscam.git -b ros2 |
There was a problem hiding this comment.
@clydemcqueen [nits] How about using COPY instead of cloning?
There was a problem hiding this comment.
Interesting idea. I will work on this a bit and propose a small PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few intermittent failures while doing some more testing on Rolling and Galactic. I traced it down to an uninitialized variable. I should have caught this earlier. :(
I also added a simple Dockerfile.
Rolling CI is failing, but this is related to ros-tooling/action-ros-ci#722
@wep21 @jbohren can you take a look?