Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Dockerfile #77

Merged
merged 4 commits into from
Feb 26, 2022
Merged

Improve Dockerfile #77

merged 4 commits into from
Feb 26, 2022

Conversation

clydemcqueen
Copy link

  • use COPY instead of git clone, this provides better support for developer workflows
  • add .dockerignore to avoid copying IDE artifacts into the docker images
  • fix usage of the ROS_DISTRO ARG. This appeared to be working before because the upstream osrf image set the ROS_DISTRO env var in the image, but it was confusing.

I re-tested the 'core 4' launch files in Foxy, Galactic and Rolling.

@jbohren @wep21 Sorry for the late PR and extra work.

clydemcqueen and others added 4 commits February 16, 2022 11:22
@clydemcqueen
Use COPY instead of git clone
2ec4c44
@clydemcqueen @wep21
Copy source into gscam
991c987 
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
@clydemcqueen
Small fixes
3ac42f3
@clydemcqueen
Merge pull request #10 from clydemcqueen/clyde_docker_workflow
8ef9831 
Use COPY instead of git clone
@wep21
Copy link
Collaborator

wep21 commented Feb 19, 2022

@clydemcqueen Thank you for the work! It looks good to me.
@jbohren Could you merge this PR if this is acceptable?

@wep21
Copy link
Collaborator

wep21 commented Feb 23, 2022

@jbohren friendly ping

@wep21 wep21 self-requested a review February 26, 2022 14:11
wep21
wep21 approved these changes Feb 26, 2022
View reviewed changes
Copy link
Collaborator

@wep21 wep21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wep21 wep21 merged commit 32c7221 into ros-drivers:ros2 Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wep21 wep21 wep21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clydemcqueen @wep21