feat: add option to use sensor data qos #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wep21
force-pushed
the
add-use-sensor-data-qos-option
branch
from
b4ed111
to
f1925d1
Compare
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
wep21
force-pushed
the
add-use-sensor-data-qos-option
branch
from
f1925d1
to
0f9f7e0
Compare
|
@jbohren @clydemcqueen Could you review this PR? This PR adds the option to use sensor data qos for camera topic. |
|
LGTM. Can you add this parameter to the README? I was hoping that we could use the new externally-configurable QoS options, but:
So for now this simple solution is the best. I tested this w/ rgb8 (the default) in Foxy, Galactic and Rolling. It should work w/ the jpeg pathway as well. |
@clydemcqueen I added the description in 496b53b. |
wep21
commented
Feb 21, 2022
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
wep21
force-pushed
the
add-use-sensor-data-qos-option
branch
from
559a184
to
532b948
Compare
|
Great, thanks! |
|
@jbohren friendly ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wep21 border_goldenmarket@yahoo.co.jp