-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ros2 gstreamer timestamps #83
Conversation
92fd449
to
2391d25
Compare
I confirmed the changes modified the timestamp in header even when use_gst_timestamps is true.
after:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@jbohren @clydemcqueen the changes look good to me. What do you think? |
LGTM. I tested this on Galactic and it works as expected. Thanks @drwnz for finding & fixing and @wep21 for moving this forward! I noticed a few unrelated bugs in the README:
/Clyde |
@clydemcqueen Thank you for confirming it. Could you create another PR to fix README? |
@drwnz Thank you for fixing the bug. |
I submitted a PR to fix the README. |
Addresses #84
When
use_gst_timestamps
was is set totrue
, timestamps converted from the gstreamer buffer timestamps would be incorrect.This is a ROS2 specific issue, caused by no constructor for
rclcpp::Time
which takes the time parameter in seconds as a float type.This PR:
use_gst_timestamps
to the readmeIt has been tested on Galactic.
@wep21