Handle different line endings #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Catch Serial exceptions and exit cleanly, instead of printing Python stack trace. - Catch Serial exception when opening the serial port, log a FATAL message, and exit instead of printing Python stack trace.
Add a NMEA socket driver node, which is like the existing serial driver node, but instead of attaching to a TTY handle from a serial port, it listens to a UDP port for NMEA sentences.
* Adds support for IMU aided GPS systems like the Applanix POS/MV, whose NMEA strings typically begin '$IN'. (e.g. $INGGA). * Adds support for VTG messages, which contain Course Over Ground and Speed Made Good. These are useful when not using RMC messages and you don't have a heading sensor.
evenator
requested changes
Jan 19, 2020
There was a problem hiding this comment.
Hi @rgov. Thanks for your contribution! I think this looks like a good fix for the issue you reported. I have one small request, and I still have to test the PR to verify it. Once all that's complete, I'll merge the PR to master and backport it to supported releases.
|
|
||
| # strip the data | ||
| data_list = data.strip().split("\n") | ||
| data_list = [ line.strip() for line in re.split(r'[\r\n]+', data) ] |
There was a problem hiding this comment.
Can you make this a compiled regex at module level to speed it up a bit?
|
Can you please rebase this PR onto the git rebase melodic-devel --onto master
git push --force |
|
Closing this to re-create it with a new source branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behavior of the socket driver to split incoming messages on different line endings including CR (
\r), LF (\n) and CRLF (\r\n). Fixes #89.