Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Capability: [CI] Add GitHub Action #116

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

130s
Copy link
Member

@130s 130s commented Feb 22, 2023

Issue

In #90 ROS2 port is happening but there's no CI config present ATM.

Branches

  • Target: ros2

Review items

  • CI passing on ROS2 humble at minimum.

@130s 130s changed the base branch from ros1 to ros2 February 22, 2023 21:21
@130s 130s force-pushed the feature-ci branch 2 times, most recently from 40d3ff3 to 21b199b Compare February 22, 2023 21:29
@mikeferguson
Copy link
Member

I'm going to merge this and then fix the actual build issues (that was my rebase, didn't notice the install issues)

@mikeferguson mikeferguson merged commit 7b9886f into ros-drivers:ros2 Feb 22, 2023
@130s 130s deleted the feature-ci branch February 22, 2023 23:59
fail-fast: false
matrix:
env:
- {ROS_DISTRO: dashing, ROS_REPO: ros, ABICHECK_URL: "github:ros-drivers/openni2_camera#ros2"}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why I added dashing...this config was a copy from another repo. Oh well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants