Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depth-only point cloud launch file for Non-RGB PrimeSense device. #132

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

TiNredmc
Copy link
Contributor

Some Depth camera based on PS1080 SoC such as Asus Xtion and (some) Xtion Pro don't come with RGB camera.

The original 'camera_with_cloud' launch file requires the missing RGB color stream, which Xtion and (some) Xtion Pro don't provide. This make point cloud topic publish no message at all.

Solving by changing depth_image_proc::PointCloudXyzrgbNode to depth_image_proc::PointCloudXyzNode and remove all RGB related topic remap in launch file. Resulted in the new launch file named 'camera_with_cloud_norgb'. Modified from 'camera_with_cloud' launch file.

I tested with these following device and environment

Signed-off-by: Tin LetHax <thipok17@gmail.com>
Copy link
Member

@mikeferguson mikeferguson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good as a temporary solution - we will eventually remove these launch files once we can fully implement openni2_launch (#120) - but that will likely be a couple more months for rolling, and will go into the J-turtle release

@mikeferguson mikeferguson merged commit e07df4e into ros-drivers:ros2 Jul 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants