Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exposure time control #46

Merged
merged 1 commit into from
Apr 29, 2017

Conversation

taketwo
Copy link
Contributor

@taketwo taketwo commented Jun 16, 2016

This pull request adds getter/setter methods for exposure time and a dynamic reconfigure option to manipulate this setting.

This commit adds getter/setter methods for exposure time and a dynamic
reconfigure option to manipulate this setting.
@taketwo
Copy link
Contributor Author

taketwo commented Jul 2, 2016

Are there any issues with this patch?

@taketwo
Copy link
Contributor Author

taketwo commented Oct 6, 2016

Hey, this is a very trivial patch. Is there any chance of merging it soon?

@130s
Copy link
Member

130s commented Oct 15, 2016

Do you think of any tests to be added to your PR?

@taketwo
Copy link
Contributor Author

taketwo commented Oct 15, 2016

I do not think so. This PR adds a trivial wrapper around a driver API function, nothing to test.

@mikeferguson
Copy link
Member

@taketwo -- not sure how, but I completely missed this PR. I'm not in the office right now to test on hardware, as soon as I get back I will test this. Just looking over it, looks good, but I have a complete set of prime sense devices I test against to make sure certain hardware doesn't cause particular regressions.

@mikeferguson mikeferguson self-assigned this Dec 21, 2016
@taketwo
Copy link
Contributor Author

taketwo commented Dec 21, 2016

No worries, thanks for taking care.
By the way, some Xtions seem to ignore this command. (From my experience, these are devices with serial numbers starting with 12.)

@mikeferguson mikeferguson merged commit c0991d9 into ros-drivers:indigo-devel Apr 29, 2017
@taketwo taketwo deleted the add-exposure-control branch April 30, 2017 08:48
@taketwo
Copy link
Contributor Author

taketwo commented Jun 20, 2017

@mikeferguson Any chance for a new release including this patch?

@130s
Copy link
Member

130s commented Aug 28, 2017

Any chance for a new release including this patch?

Done #49 (comment)
Binary should become available in the next public sync (watch https://discourse.ros.org/c/release if interested).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants