Add option to turn off packet resend #163
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FinnLinxxx Would this help with issue #155 ? This PR will help us with our issue! |
|
@mikepurvis Greetings, who can review and approve this pull request? This is very important change to my robosub team. |
|
@Sindorman Change looks reasonable to me. Have you validated by running the driver from source that this change improves performance for you? |
|
@mikepurvis I have not. I will see if I can compile and run it. Interesting note: Flea3 GigE Camera FL3-GE-14S3C-C documentation says that Packet Resend is supported. |
|
@mikepurvis We have tested the branch source code, compiled and integrated with all ROS drivers, it works well!! I think it is good to go to be merged! Cameras live test shows everything works the same as on indigo. |
Sindorman
approved these changes
Jun 23, 2018
Sindorman
approved these changes
Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My camera (Flea3 GigE Camera FL3-GE-14S3C-C) does not work properly with the current git/master. It is not able to turn on the packet_resend option as set by #97 (hardwired) ( Issue #158 ). This PR adds the option to turn off packet resend before runtime.
ex1
ex2
true is still the default value.