Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noetic support #49

Merged
merged 5 commits into from Jun 3, 2020
Merged

Noetic support #49

merged 5 commits into from Jun 3, 2020

Conversation

130s
Copy link
Member

@130s 130s commented Jun 2, 2020

Addresses #48

Branch

  • Based off of jade-devel (which is used for up to ROS Melodic release)
  • Target: noetic-devel (which I just branched off of jade-devel).

CoS

  • CI cnofig update. CI should pass.

@130s
Copy link
Member Author

130s commented Jun 2, 2020

@mikeferguson Thanks for your input in #48. On CI that uses focal, I wanted to see if the CI jobs fails without CMakeLists.txt change and it actually didn't. Not yet sure if that is ok.

@130s
Copy link
Member Author

130s commented Jun 2, 2020

I guess this is launch only package basically, so CI not failing/warning is probably fine. Regardless, I've pushed cmake change.

@130s 130s changed the title WIP: Noetic support Noetic support Jun 2, 2020
@130s 130s merged commit 7c661ee into noetic-devel Jun 3, 2020
@130s 130s deleted the release-noetic branch June 3, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant