Create Full UDP Nodes #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flynneva
approved these changes
Mar 8, 2021
|
@JWhitleyWork lets go ahead and merge this. I can take it from there and switch it over to use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates
UdpReceiverNodeandUdpSenderNodeas well as a bridge node which includes both. These are created as both component nodes and managed lifecycle nodes.@flynneva Would you be able to review this one too? Finally, it's time for me to get to bed. Could you possibly look into modifying
UdpSenderNode,UdpReceiverNode, and the associated tests so they useudp_msgsdirectly instead of this message converter stuff? While the converters might be useful for some, they shouldn't be the default for stand-alone nodes (I just didn't have time to change them).