Feature/udp component #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@reza-ebrahimi looks like for Dashing (Ubuntu 18.04) it doesn't like how you did the |
|
Try with this one: |
|
See my feedback on #31. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds on to #31 with a generic
udp_nodecomponent. this is semi-functional as-is, just missing one step.that step is to copy from the boost
mutable_bufferover to astd::vector<uint8_t>type. im definitely not a cpp expert here and would ask for some advice from @JWhitleyWork or anyone else.overall i thought working with the updates from #31 was a lot easier than before, and im loving where this package is heading.