Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cut_angle by default. #497

Merged
merged 1 commit into from May 27, 2023
Merged

Disable cut_angle by default. #497

merged 1 commit into from May 27, 2023

Conversation

JWhitleyWork
Copy link
Contributor

Prior to the cut_angle feature being added, the default behavior was to consider a complete rotation to be a set number of packets. This feature being added and enabled by default changed the default behavior subtley and caused undesired effects. This PR reverts that change but leaves the cut_angle feature available for those who choose to use it.

@JWhitleyWork
Copy link
Contributor Author

@cjffly Please confirm that this change resolves your issue.

@JWhitleyWork JWhitleyWork merged commit 026a4f0 into ros2 May 27, 2023
@JWhitleyWork JWhitleyWork deleted the disable-cut-angle branch May 27, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant