Add Polygon Info obtained from zbar #11
Conversation
ijnek
force-pushed
the
rolling-with-polygon-info
branch
from
ead60f7
to
eeb9e51
Compare
ijnek
force-pushed
the
rolling-with-polygon-info
branch
2 times, most recently
from
0e90eda
to
6667687
Compare
|
CI is failing because of an upstream issue in ament_cmake.. |
|
@paulbovbel would you be able to review the changes in this PR, and if you agree with the changes, do you think there's a better way to deprecate the existing topic? |
|
@ijnek sorry I missed this. You should consider deprecating the topic for the upcoming Iron release, and then removing it in rolling. |
| @@ -0,0 +1,36 @@ | |||
| cmake_minimum_required(VERSION 3.5) | |||
| project(zbar_ros_interfaces) | |||
There was a problem hiding this comment.
Usually these packages are labeled _msgs rather than _interfaces in the ROS ecosystem.
There was a problem hiding this comment.
My understanding is _msgs is the old ROS 1 convention, and _interfaces is the new ROS 2 convention.
Ref:
https://docs.ros.org/en/rolling/Tutorials/Beginner-Client-Libraries/Custom-ROS2-Interfaces.html
https://roboticsbackend.com/ros2-create-custom-message/ ("End with “_interfaces” so it’s clear the package is an interface package. You’ll often see packages ending with “_msgs”, but this is the old convention.")
| RCLCPP_DEBUG(get_logger(), "Barcode detected with data: '%s'", symbol.data.c_str()); | ||
|
|
||
| RCLCPP_DEBUG( | ||
| get_logger(), "Polygon around barcode has %d points", symbol_it->get_location_size()); |
There was a problem hiding this comment.
It's a shame vision_msgs only has 'bounding box' type boundaries rather than the polygons zbar reports.
ijnek
force-pushed
the
rolling-with-polygon-info
branch
from
df40d8a
to
124e4ba
Compare
|
Rebased onto |
Signed-off-by: ijnek <kenjibrameld@gmail.com>
Fix print formatting Signed-off-by: ijnek <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
Signed-off-by: Kenji Brameld <kenjibrameld@gmail.com>
ijnek
force-pushed
the
rolling-with-polygon-info
branch
from
124e4ba
to
233697f
Compare
|
CI failure due to ros-tooling/setup-ros@v0.7 having no support for ubuntu noble, but confirmed that ci passes if using ros-tooling/setup-ros@master |
Use an interface
zbar_ros_interfaces/msg/Symbol.msgto communicate more information about the qr code that is available in zbar.Deprecated the "barcode" topic in favor of the "symbol" topic (I needed a different name for the topic to avoid msg type conflict). A deprecation warning shows up in the zbar_ros_node when a subscription is detected on the 'barcode' topic.
Before merging,
ros2branch torolling, to adhere to recommendations from OpenRobotics.