Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing dependency to catkin_package() #13

Merged
merged 1 commit into from
Aug 29, 2014

Conversation

roehling
Copy link
Contributor

Message generation depends on geometry_msgs, thus this dependency must be propagated in catkin_package().

jack-oquin added a commit that referenced this pull request Aug 29, 2014
add missing dependency to catkin_package()
@jack-oquin jack-oquin merged commit 4cdadcd into ros-geographic-info:master Aug 29, 2014
@jack-oquin
Copy link
Member

Thanks, Timo! Good catch.

@mikepurvis
Copy link
Member

Doesn't this only affect linking? I thought a build_depend/run_depend was sufficient for messages, since they're header-only.

@jack-oquin
Copy link
Member

The catkin API how-to recommends it, so it seems better to do it that way.

It does currently seem to work without the explicit find_package() component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants