Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate version detection of EGM protocol #46

Closed
gavanderhoorn opened this issue Apr 18, 2019 · 4 comments · Fixed by #81
Closed

Investigate version detection of EGM protocol #46

gavanderhoorn opened this issue Apr 18, 2019 · 4 comments · Fixed by #81
Assignees
Labels
enhancement New feature or request

Comments

@gavanderhoorn
Copy link
Member

With the requirement of using at least version 6.07.01 of RobotWare in #32, we've had a few reports of users running into issues when trying to use an older version of RW (see #42 and #45).

It would be good if abb_libegm supported some sort of version check, as this could help us print an error message if/when an incompatible version is being used.

@gavanderhoorn
Copy link
Member Author

With a wider range of RW 6 versions available now, the potential for unexpectedly running into an incompatible RW version has increased.

Have you had any time to look at how to implement some form of version detection @jontje?

@jontje
Copy link
Contributor

jontje commented Nov 26, 2019

Have you had any time to look at how to implement some form of version detection @jontje?

Not yet, but I have an idea of how to do it.

I have a couple minor PRs prepared after this one #63, and after that I am working on another related to RW6.10. I can investigate about version checking in that one.

@gavanderhoorn
Copy link
Member Author

@jontje: friendly ping again :)

We have even more RW6 versions now then when I wrote #46 (comment), so this may be something valuable to have (ie: the ability to detect versions, and block incompatible ones).

@jontje
Copy link
Contributor

jontje commented Feb 6, 2020

@jontje: friendly ping again :)

Thanks for the reminder 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

2 participants