Lower minimum required CMake version #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll wait for CI to turn green and then merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current required CMake version
3.9.1, the packages don't build on Kinetic.Kinetic will be EOL pretty soon, but there is actually nothing in the
CMakeLists.txtwhich requires such a recent CMake version -- they're pretty vanillaCMakeLists.txts for ROS 1 msg packages.This solves the build issues of the (yesterday) released pkgs on Kinetic without influencing the build on other OS/ROS versions.
Failed build on the buildfarm: Kbin_uX64__abb_rapid_msgs__ubuntu_xenial_amd64__binary/2.