Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #83: add comments to TP Ps, PRs and Fs #280

Merged
merged 1 commit into from Oct 9, 2019
Merged

Fix issue #83: add comments to TP Ps, PRs and Fs #280

merged 1 commit into from Oct 9, 2019

Conversation

gavanderhoorn
Copy link
Member

As per subject.

These will be applied to the actual Ps, PRs and Fs on the controller when the .tp is loaded.

No functional changes.

This is a draft for now, as I need to verify this on real hw.

@gavanderhoorn gavanderhoorn added this to the untargeted milestone Oct 8, 2019
@gavanderhoorn
Copy link
Member Author

#83.

@gavanderhoorn
Copy link
Member Author

If any of you could review, I'll merge.

dejaniraai
dejaniraai approved these changes Oct 9, 2019
View reviewed changes
Copy link

@dejaniraai dejaniraai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have taken a look at the changes and they seem fine.

@gavanderhoorn gavanderhoorn marked this pull request as ready for review October 9, 2019 11:51
@gavanderhoorn gavanderhoorn merged commit fe229fa into ros-industrial:indigo-devel Oct 9, 2019
@gavanderhoorn gavanderhoorn deleted the issue83_reg_comments branch October 9, 2019 11:51
@gavanderhoorn
Copy link
Member Author

Thanks again @dejaniraai 👍

@gavanderhoorn gavanderhoorn mentioned this pull request Oct 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dejaniraai dejaniraai dejaniraai approved these changes

@ipa-nhg ipa-nhg Awaiting requested review from ipa-nhg

@Levi-Armstrong Levi-Armstrong Awaiting requested review from Levi-Armstrong

Assignees
No one assigned
Labels
None yet
Milestone
untargeted
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gavanderhoorn @dejaniraai