Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rgbd fixes #76

Merged
merged 5 commits into from
Apr 6, 2016
Merged

Rgbd fixes #76

merged 5 commits into from
Apr 6, 2016

Conversation

akgoins
Copy link
Contributor

@akgoins akgoins commented Mar 29, 2016

@drchrislewis, please review. This includes some code cleanup but primarily fixes depth_calibration.cpp to correctly handle special cases (NaN's in the point cloud, large stddev in target pose calculation, etc.).

@drchrislewis drchrislewis merged commit 7d762c1 into ros-industrial:indigo-devel Apr 6, 2016
@jdlangs
Copy link
Member

jdlangs commented Aug 9, 2017

@akgoins, it would be nice not to force a dependency of openni_camera on all users of this repository, especially if they have no need for the rgbd_depth_correction package. Will it be alright to change this back to reading the config file from a parameter instead of directly calling for the serial number?

@akgoins
Copy link
Contributor Author

akgoins commented Aug 10, 2017

Yes, it would be fine to go back to a parameter. I did this to make the cameras hot swappable, but using a parameter would make it easier to use with other cameras which don't have a service for getting the serial number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants