Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix usermod error on docker-based ROS Prerelease #81

Merged
merged 1 commit into from
Oct 23, 2016

Conversation

130s
Copy link
Member

@130s 130s commented Oct 22, 2016

Without knowing, docker install instruction might have been updated to NOT use the user ubuntu. They surely updated URL of the page.

This fixes issues like ros-industrial/ros_canopen#193 (comment) (confirmed on my fork that with this change Travis passed 130s/ros_canopen#3).

@mathias-luedtke
Copy link
Member

I would guess that Travis just migrated their VMs and just dropped the ubuntu user in favor of something else.

$USER (or even better $(whoami)) does not assume a specific username.

+1 for merge :)

@130s
Copy link
Member Author

130s commented Oct 23, 2016

even better $(whoami)

Agreed (ref). Switched to it. Once Travis passes it's mergeable.

BTW, the section of the code that caused the error ros-industrial/ros_canopen#193 (comment) should be reached only when you enable PRERELEASE=true, which at the time of the PR is not enabled in .travis.yml. Indeed in a successful Travis build in my forked repo it's not reached. I'm not sure if there's an uncovered bug.

@mathias-luedtke
Copy link
Member

I'm not sure if there's s uncovered bug.

I have a dedicated test-release branch which the PR was targeted at:
https://github.com/ros-industrial/ros_canopen/blob/test-release/.travis.yml

@130s
Copy link
Member Author

130s commented Oct 23, 2016

I have a dedicated test-release branch which the PR was targeted at:
https://github.com/ros-industrial/ros_canopen/blob/test-release/.travis.yml

😌

@130s 130s merged commit 6f4f5bf into ros-industrial:master Oct 23, 2016
@130s 130s deleted the fix/ros_canopen/193 branch October 23, 2016 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants