Setting github output for failed colcon test-result broken

[fmauch]

Hi,

after debugging a bit it seems to me that output reporting for a failed colcon test-result is broken.

I have setup a minimal project with a small C++-"library" and a gtest.

In the workflow I run ICI and print some ici outputs:

      - uses: 'ros-industrial/industrial_ci@master'
        env:
          ROS_DISTRO: ${{ matrix.ROS_DISTRO }}
          ROS_REPO: ${{ matrix.ROS_REPO }}
        id: ici
      - name: Print ICI outputs
        if: ${{ always() }}
        run: echo 'build_target_workspace is ${{ steps.ici.outputs.build_target_workspace }}, run_target_test is ${{ steps.ici.outputs.run_target_test }}, target_test_results is ${{ steps.ici.outputs.target_test_results }}'

When everything succeeds, this prints

build_target_workspace is 0, run_target_test is 0, target_test_results is 0

However, when I add a deliberate failure to the gtest the result is

build_target_workspace is 0, run_target_test is 0, target_test_results is 

I verified that running the same commands (stripped by ici wrapping) locally

err=0
colcon test
colcon test-result --verbose || err=$?
echo "Test result: $err"

prints Test result: 1 in the end so I'm not sure whats going on here.

[mathias-luedtke]

Thanks for reporting!
I can confirm that the output will not get reported properly.
My guess is that it never worked as expected, because this line is never reached:

industrial_ci/industrial_ci/src/workspace.sh

Line 404 in 6931750

ici_report_result "${name}_test_results" "$err"